search

transfem-org / Sharkey

🌎 A Sharkish microblogging platform 🚀
https://joinsharkey.org/
73 stars 19 forks source link

feat: Keyboard support & proper labeling of things #80

Open Freeplayg opened 11 months ago

Freeplayg commented 11 months ago

Summary

Am not sure if this should count as a bug or feature, but having keyboard support, as well as properly labeling buttons for screen readers should be a needed thing.

I know one way most of the labeling was done in Firefish was setting the aria-label attribute in the script that adds the tooltips, so that should make that bit easier. Some cherry-picking could also probably be done for especially the form components i think? I hope I didn't make those commits too messy, I'll try to find them later Edit: This should be the commit for the form inputs in Calckey: https://codeberg.org/firefish/firefish/commit/1cc7c3f8dd685cc0ec62d55b0bdaf32c0475735c (https://codeberg.org/firefish/firefish/pulls/10130/files) I hope that not much has changed in misskey's input components ?

Buttons should also have an outline shown when they're focused

There's a bunch more stuff that would need to be done, but that's the most basic stuff to make it at least sort of usable. Am still learning this stuff also

Kio-td commented 11 months ago

Related: #23

Mar0xy commented 11 months ago

"but having keyboard support" don't really what is meant with this as you can scroll using the keyboard as well as switch light/dark mode, open new post dialog

Freeplayg commented 11 months ago

keyboard support as in being able to tab through every button, basic accessibility (edit: Try navigating without a mouse at all.)

There's more to it than that, i just only really know how to explain the bare minimum lol