transfer4D / transfer4D.github.io

Website for "Transfer4D: A framework for frugal motion capture and deformation transfer, CVPR 2023"
6 stars 2 forks source link

Some issues in setting up the repository and running code #2

Open tykim5931 opened 1 week ago

tykim5931 commented 1 week ago

Thank you for sharing your impressive work. I appreciate the opportunity to explore it.

I encountered some issues when trying to run the provided code. It appears that certain files may be missing, which is causing errors during execution. I reviewed the NRR.py file specifically, but several other files also seem to have missing import statements. For your reference, I’ve attached screenshots of the code and corresponding error messages below.

It seems that run_lepard, run_motion_model, and lepard.inference are missing, and the lepard repository does not include the inference.py file.

image image image

Additionally, when we replace the mainCmd.cpp file in the dem-bones repository with the version in Code/dem-bones/, the CMake build for the dem-bones project fails.

Could you please advise on any possible solutions to address these issues? Your guidance would be greatly appreciated.

Thank you very much!

shubhMaheshwari commented 1 week ago

Hi @tykim5931,

I have updated the supplementary code (see Code/src) and uploaded the missing files. Can you clone this repository and try to run the commands mentioned in the README. Let me know what issues you encounter.

Also for running dem-bones 2 files (DemBones.h and mainCmd.cpp) have to be updated.

tykim5931 commented 4 days ago

Hello, Thanks a lot for your kind reply! I am sorry for late reply. I'm trying out building the code. Running dem-bones build with the updated mainCmd.cpp outputs an error.

/home/lucy/ssd/Codes/transfer4D.github.io/Code/src/dem-bones/src/command/mainCmd.cpp:8:10: fatal error: NumpyReader.h: No such file or directory
    8 | #include "NumpyReader.h"
      |          ^~~~~~~~~~~~~~~
compilation terminated.
shubhMaheshwari commented 4 days ago

I have added the 2 files (NumpyReader.cpp and NumpyReader.h) See ac506f44faef66ecbdecac0f3fba88f7f915ea38

Modification for the custom SSDR implementation:

  1. Clone dem-bones.
  2. Replace mainCmd.cpp with Code/src/dem-bones/mainCmd.cpp
  3. Replace include/DemBones.h with Code/src/dem-bones/DemBones.h
  4. Copy Code/src/dem-bones/NumpyReader.{h,cpp} into their src/
tykim5931 commented 3 days ago

I guess building the NumpyReader file requires the Python.h file for building. If it doesn't bothers you a lot, could you upload all the missing header files in the original dem-bones repo? I've listed files under the dem-bones/src/command folder.

AbcReader.cpp
AbcReader.h
FbxReader.cpp
FbxReader.h
FbxShared.cpp
FbxShared.h
FbxWriter.cpp
FbxWriter.h
LogMsg.cpp
LogMsg.h
mainCmd.cpp
NumpyReader.cpp
NumpyReader.h

and following is the error message I've got.

/usr/include/pybind11/detail/common.h:215:10: fatal error: Python.h: No such file or directory
  215 | #include <Python.h>
      |          ^~~~~~~~~~
shubhMaheshwari commented 3 days ago

I am unsure this is being caused by NumpyReader.cpp. Seems like a issue when python is not installed or not correctly included during make. See: https://github.com/pybind/pybind11/issues/1781

Were you able to build the original dem-bones library? It has a lot of libraries and found it quite difficult to install. You will require:

For your convenience, I am making my implementation public. See: https://github.com/shubhMaheshwari/pyssdr . It should have the same setup procedure to build.

mkdir -p build && cd build && cmake .. && make 
tykim5931 commented 3 days ago

I thought that the issue was caused by NumpyReader.cpp since I succeeded in building the dem-bones with the original repo...

And about the required packages, I've installed the Eigen, FBXSDX, Albemic, and tclap that are listed in the dem-bones readme. I had no issue to build the original repo.

And maybe the importing Python.h error is caused by the pybind11 library.. I'll check the link of the pybind issue page.

Thank you for your kindness:) I'll try again with installing OpenExr, IMath, and pybind11.

shubhMaheshwari commented 3 days ago

The issue could also be with the CMakeLists.txt

Can you replace yours with this CMakeLists.txt and try to compile again.