Remove float precision in Least Angle Regression

transferwise / hisel

Feature selection tool based on Hilbert-Schmidt Independence Criterion

Apache License 2.0

2 stars 0 forks source link

Remove float precision in Least Angle Regression #43

Closed claudio-tw closed 1 year ago

claudio-tw commented 1 year ago

Context

The original implementation of the Least Angle Regression was in cython. This entailed specifying the precision of float and int in the numpy arrays. We no longer need that, and this PR reverts back to using the keyword float and int

Checklist

[x] Change meets or does not compromise the Baseline Security Requirements

wise-github-bot-app[bot] commented 1 year ago

The approval(s) from AlxdrPolyakov do(es)n't fullfill the approvers requirements because:

The approver's cost centre, PRDANA, maps to the ANALYST business function. As the code that was changed is owned by ENGINEERING, this approval won't satisfy our separation of duties check. We'll need an additional approval from someone in ENGINEERING. This approval may still help satisfy other codeowner requirements.