transferwise / hisel

Feature selection tool based on Hilbert-Schmidt Independence Criterion
Apache License 2.0
2 stars 0 forks source link

TW requirements - Write codeowners #9

Closed claudio-tw closed 1 year ago

claudio-tw commented 1 year ago

Context

tw requirements entails that every repository must have a CODEOWNERS file. This PR adds such a file.

Checklist

wise-github-bot-app[bot] commented 1 year ago

:red_circle:

Your CODEOWNERS file is broken, fix the following errors before merging the branch:

pereplanellTW commented 1 year ago

/wise-bot run-checks

wise-github-bot-app[bot] commented 1 year ago

:green_circle:

All the checks were successfully run again...

elodani-transferwise commented 1 year ago

/wise-bot help

wise-github-bot-app[bot] commented 1 year ago

These are all the things I can do:

approve: Creates synthetic approvals for retrospective reviews. emergency-merge: Merges the PR even with failed checks. Use only under emergencies. ping: Check if the bot is properly listening run-checks: Runs all checks in the PR. Use it if the automatic run was buggy run-action: Forces a specific action to run

elodani-transferwise commented 1 year ago

/wise-bot run-action help

wise-github-bot-app[bot] commented 1 year ago

:red_circle:

Invalid action to run, these are the available ones:

elodani-transferwise commented 1 year ago

/wise-bot run-checks

wise-github-bot-app[bot] commented 1 year ago

:green_circle:

All the checks were successfully run again...

elodani-transferwise commented 1 year ago

FTR as there is no codeowners present on master, and the service is not in census (lol), the bot is deeming everyone who is not a product engineer unworthy. (I am 99% sure if someone who is not a platformer (or analyst) but a regular product engineer approves it will count as valid.... the other 1% is emergency merge only :D

krisztiankoszegi commented 1 year ago

/wise-bot emergency-merge CI pipeline blocked

wise-github-bot-app[bot] commented 1 year ago

:green_circle:

Emergency merge requested by krisztiankoszegi.

This event has been added to the security log. The merge could take few seconds...

Remember that, once it is merged, a maintainer should review the code and approve it retrospectively by commenting /wise-bot approve within 14 days to avoid an SLA breach.

Requester krisztiankoszegi
Reason CI pipeline blocked
Merge Method squash
wise-github-bot-app[bot] commented 1 year ago

Your CODEOWNERS or the tw-rules.yaml file has changed. Syncing your GitHub teams with your CODEOWNERS file and extraWriters in tw-rules:

Collaborator Name Synced Comment
analysts-product :green_circle: Team updated with role owner

You have more info in the docs

elodani-transferwise commented 1 year ago

/wise-bot approve

wise-github-bot-app[bot] commented 1 year ago

:red_circle:

Sorry, your approval is not valid because of the following reasons:

AlxdrPolyakov commented 1 year ago

/wise-bot approve

wise-github-bot-app[bot] commented 1 year ago

Approved by AlxdrPolyakov