search

transferwise / openbanking-client

Java client for using the UK Open Banking API
Other
15 stars 14 forks source link

Replace RestTemplate with WebClient #11

Open mscott-tw opened 3 years ago

mscott-tw commented 3 years ago

We currently use the Spring RestTemplate class for executing the API calls to the ASPSP, this class is now in maintenance mode and won't get new functionality, Spring advises developers to instead use the WebClient class.

Therefore it would be good to refactor the RestTemplate usage in favour of WebClient usage.

That shouldn't be particularly difficult, but one thing to think about is whether we change the PaymentClient and RegistrationClient interfaces to expose the reactive (Mono) aspects of WebClient or we continue using the current approach.

antonio-pedro99 commented 1 year ago

@mscott-tw is this issue still open?

mscott-tw commented 1 year ago

Personally I would say so, the listed reasons for switching to WebClient are still valid and our internal tooling is geared around WebClient now (though this is less important for external clients). Just a case of whether it's worth prioritising it or not. Though I would be tempted to take this on one evening :smile:

antonio-pedro99 commented 1 year ago

@mscott-tw indeed, I would like to work on that.

mscott-tw commented 1 year ago

Sure, by all means welcome to take on this item.

antonio-pedro99 commented 1 year ago

@mscott-tw thanks!