Closed menzenski closed 3 months ago
Looks like duplicate of #160
Someone smarter than me might want to chip on which version of the solution is more appropriate 🤷
In absence of a Maintainer review (5 months at time of writing this), the backwards compatible import fix in #160 is cleaner. I would suggest to build off #160 and then apply your psycopg2
dependency update. Also might be worth bumping to the current version which looks to have python3.12 support from 3.1.3+ (https://github.com/psycopg/psycopg/issues/305).
There's currently no automated validation for the fix. My suggestion would be to add a python 3.11 CI job.
Context
This PR is necessary because in Python 3.10 and above,
MutableMapping
cannot be imported from thecollections
package - it must be imported fromcollections.abc
. Per the documentation:The
collections.abc
import is supported in earlier versions of Python as well. I've personally tested this change down to Python 3.7.Checklist
^ I can't view that Baseline Security Requirements document, but I don't believe this PR has any negative impact on security.