transhumandesign / kag-base

King Arthur's Gold base folder.
256 stars 118 forks source link

[fixed] Archer could continue stabbing or charging Arrow while attached & [fixed] wrong charge cursor for Knight and Archer while attached #2025

Open mugg91 opened 2 months ago

mugg91 commented 2 months ago

Status

Description

[fixed] Archer continued to charge Arrow when sleeping in a quarters
[fixed] Archer's stabbing state could continue after sleeping in a quarters
[fixed] Archer's cursor frame didn't reset when Archer got attached
[fixed] Knight cursor frame didn't reset when Knight got attached

Fixes https://github.com/transhumandesign/kag-base/issues/2024 Fixes https://github.com/transhumandesign/kag-base/issues/2018

This PR makes fixes to ArcherLogic.as so Archer won't be able to charge Arrows "in their sleep". It was also possible to press Action_2 to start stabbing a log, quickly start sleeping, and then Archer would fletch an arrow even when not pressing any keys.

When getting attached while charging, the cursor frame kept the charging meter. After this PR it will reset to indicate there is no charging.

KnightLogic.as was changed to fix an issue with the charge cursor having the wrong frame when getting attached while charging.

Please note this PR doesn't incorporate other PRs merged in since the current live build 4541. I might try to incorporate that in the future. For now I'm focusing on getting things to work based on the live build.

Please note this PR doesn't fix Knight's double slash bug. For that please see: https://github.com/transhumandesign/kag-base/pull/1839

Tested in offline and online.