search

transhumandesign / kag-base

King Arthur's Gold base folder.
258 stars 119 forks source link

Dirt back tile bug #2144

Closed mugg91 closed 2 hours ago

mugg91 commented 2 hours ago

Description

Under certain circumstances, destroying stone tiles that were placed on dirt back tiles would erroneously turn into empty (air) tiles instead of going back to being dirt back tiles.

Also, under certain circumstances, empty (air) tiles could turn into dirt back tiles.

I don't understand the exact reasons.

screen-24-06-24-12-05-50 Here I built a gigantic pyramid in Sandbox EU, then we destroyed it. As seen in the screenshot, many rows turned into empty air tiles.

screen-24-10-18-13-25-39 In this screenshot there are dirt back tiles that shouldn't be there. It was like this when I joined.

Vam-Jam commented 2 hours ago

Duplicate of #2122 , fixed for next update.

Video of the patch: https://fs.vamist.dev/e3a815-Replay_2024-09-09_09-37-55.mp4

The client never knew enough information to generate dirt background support if you were not in the game since the map switched.

This leads to the following (known) issues:

    Stone tiles removing dirt background on rejoin
    Backgrounds replacing dirt background on rejoin
    Any wall connected to a dirt/bedrock ceiling will generate dirt background on rejoin

This PR has the server send u8 dirt level whenever SendMapTile is called.