search

transient-haskell / transient

A full stack, reactive architecture for general purpose programming. Algebraic and monadically composable primitives for concurrency, parallelism, event handling, transactions, multithreading, Web, and distributed computing with complete de-inversion of control (No callbacks, no blocking, pure state)
MIT License
630 stars 28 forks source link

Cosmetic changes #36

Closed rahulmutt closed 7 years ago

rahulmutt commented 7 years ago

If you like the cosmetic changes, I can do the same to the other core Transient modules as well before you merge this PR.

geraldus commented 7 years ago

@rahulmutt Hi! Very glad to see this stuff (I tended to do it myself but still have other duties). I'll review already pushed code. Go ahead with other modules too!

geraldus commented 7 years ago

@agocorona @rahulmutt I found present review system a bit confusing. When reviewing please switch to Files changed tab. This way you could see review comments with all surrounded code, not a small chunk of it. It looks like easiest way to review.

geraldus commented 7 years ago

@rahulmutt are you finished with this?

rahulmutt commented 7 years ago

@geraldus Almost. I have a couple minor changes left and I'll give a confirmation in a couple days.

harendra-kumar commented 7 years ago

I like the changes in this PR, I wanted to do some of those myself but resisted. Is anyone working to merge this one? Seems to be a bit of work because of the conflicts.

agocorona commented 7 years ago

@harendra-kumar I tried to solve the conflicts some time ago. I don´t know if this is the cause.

harendra-kumar commented 7 years ago

@rahulmutt after your latest PR getting merged, can this be closed?

rahulmutt commented 7 years ago

Closing, since this is outdated and unmergeable. Will submit smaller, individual PRs.