search

transientskp / pyse

Python Source Extractor
BSD 2-Clause "Simplified" License
11 stars 5 forks source link

Fix values attribute override #57

Closed HannoSpreeuw closed 4 months ago

HannoSpreeuw commented 4 months ago

Should fix #52

All 105 unit tests pass (1 skipped).

@suvayu Pls let me know if mypy thinks this is sufficient.

HannoSpreeuw commented 4 months ago

I see that some mypy type-checks, as included in our updated CI, have failed. Those have nothing to do with this PR. So these problems must have been present before.

I should be running mypy myself I guess. How can I run exactly these mypy tests within PyCharm or from bash?

suvayu commented 4 months ago

I'll comment on the other points later.

How can I run exactly these mypy tests within PyCharm or from bash?

hatch run lint:mypy in the terminal. To run inside PyCharm, I don't know exactly, but there should be an option under linting/type checker.

HannoSpreeuw commented 4 months ago

Thanks, hatch run lint:mypy works and shows errors (and notes).

suvayu commented 4 months ago

All 105 unit tests pass (1 skipped).

The single skip is because of the dependency on the large dataset. It only runs if you put the dataset there manually. I added this test to fix the issue reported by Timo. I'll make it mandatory after we find a solution for the large dataset issue. I've an idea of what we could do, haven't investigated yet.

I see that some mypy type-checks, as included in our updated CI, have failed.

I expect that step to fail until all the issues I opened recently are resolved (I think there might be some others where I did not file an issue because the resolution wasn't clear to me).