PostgreSQL 14 support - Githubissues

transientskp / tkp

A transients-discovery pipeline for astronomical image-based surveys

http://docs.transientskp.org/

BSD 2-Clause "Simplified" License

19 stars 14 forks source link

PostgreSQL 14 support #605

Closed jhidding closed 1 year ago

jhidding commented 1 year ago

This PR adds compatibility with PostgreSQL version 14, based on top of @HannoSpreeuw 's port to Python 3 (so #596 should be merged first).

The functions in tkp/db/sql/statements/functions now follow a Jinja2 template instead of the custom mini preprocessor language that was there before.
Jinja2 is added as direct dependency (it was already a transitive dependency).
The major version of the DB engine is used to dispatch between PG14 and earlier versions, keeping compatibility with older Postgres installations.

AntoniaR commented 1 year ago

I tried this out. Unsurprisingly it failed the tests on my system as our database server is not running PostgreSQL 14. I'm very reluctant to try updating the PostgreSQL version on that machine as it could impact ongoing science with the folks using that machine.

I propose to create a new release of the current master branch - i.e. the python 3 version and improvements. Then this branch could be merged with the master branch. However, I would like to run the tests successfully myself before merging. Are there any straight forward instructions for setting up PostgreSQL in a conda environment?

HannoSpreeuw commented 1 year ago

@AntoniaR I have been using this gist quite a bit. Pls let me know if it serves your purpose.

AntoniaR commented 1 year ago

Apologies for the delay with this PR. The gist helped a lot. I now have this version running and all the tests passed.

There was a missing import command in tkp/main.py (import imp) but I will get that corrected.