search

transientskp / tkp

A transients-discovery pipeline for astronomical image-based surveys
http://docs.transientskp.org/
BSD 2-Clause "Simplified" License
19 stars 14 forks source link

Separate pyse #619

Closed tmillenaar closed 1 week ago

tmillenaar commented 1 month ago

This PR removes the internal sourcefinder and it's tests and replaces it with radio-pyse.

Put on top of the PR for testing in CI: https://github.com/transientskp/tkp/pull/618

HannoSpreeuw commented 1 month ago

I guess this also needs @suvayu 's review, so I'll add him.

HannoSpreeuw commented 1 month ago

Fixes https://github.com/transientskp/tkp/issues/616 I reckon.

HannoSpreeuw commented 1 month ago

But we still have the ERROR: No matching distribution found for radio-pyse>=0.3.1 (from tkp==4.0) build problem.

suvayu commented 1 month ago

I think that's because of the container issue. It's using an older Python, and since 0.3.0, PySE requires 3.10. This will be resolved when python-casacore makes a new release, as then there would be no need for the container.