search

transifex / transifex-client

The Transifex command-line tool.
https://www.transifex.com/
GNU General Public License v2.0
136 stars 76 forks source link

python-slugify requirement clashes with existing awesome-slugify #220

Open awbacker opened 6 years ago

awbacker commented 6 years ago

We have been using awesome-slugify for quite some time now, due to very handy helpers like slugify_url and its handling of unicode/chinese characters.

v0.13 of transifex-client now installs python-slugify which also uses the same module name slugify, causing a conflict. On our production systems the transifex client is not installed, so this isn't causing an issue, however in our dev environment it is.

Not sure what can be done about this, short of offering an option like pip install transifex[awesome-slugify] or having the projects re-namespace (as they should have before now!).

I will look into changing which slugify we use, but then we may run into issues where I peg to a lower version and then transifex-client requires a newer one.

tjerkw commented 5 years ago

We had the same issue, its a problem with python dependency management (which is a hell anyways). I think transifex should implement their own slug function instead of depending on an external library.

awbacker commented 5 years ago

I think they should vendor this dependency at least. We've moved onto python_slugify too now, so not as big an issue.

The main problem, small one, is that the pinned versions of slugify and six are old, and we use newer ones. I just ignore the warning, but it would be good if they had broader versions allowed, since people don't usually use tfx standalone, but rather part of s larger project and are likely to have these packages installed as well.

On Sat, Mar 23, 2019, 14:20 Tjerk Wolterink notifications@github.com wrote:

We had the same issue, its a problem with python dependency management (which is a hell anyways). I think transifex should implement their own slug function instead of depending on an external library.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/transifex/transifex-client/issues/220#issuecomment-475865239, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGToi2toWjmnDkGoIOfGevLR3t_1c1Dks5vZhv6gaJpZM4S2YVM .

mikix commented 5 years ago

I'll add that python-slugify and awesome-slugify also conflict with Mozilla's unicode-slugify. :disappointed: