[DNM]Fix issue with pinned dependencies

transifex / transifex-client

The Transifex command-line tool.

https://www.transifex.com/

GNU General Public License v2.0

136 stars 76 forks source link

[DNM]Fix issue with pinned dependencies #253

Closed Diontsoumas closed 4 years ago

Diontsoumas commented 5 years ago

Pinning dependencies in a specific version break compatibility with 3rd party integrations. In order to fix that, we remove any hardcoded minor versions and replace the hard dependency with an upper limit one.

This fixes https://github.com/transifex/transifex-client/issues/211#issuecomment-443416109 and https://github.com/transifex/transifex-client/issues/252 where the Transifex client could not be installed due to hard pinned dependencies.

feanil commented 5 years ago

Alternative PR that pins to the current major versions without pinning to the exact minor/patch versions: https://github.com/transifex/transifex-client/pull/259

diegobz commented 4 years ago

Closing this in favor or #273.