Pin to major version but not to minor or patch.

transifex / transifex-client

The Transifex command-line tool.

https://www.transifex.com/

GNU General Public License v2.0

136 stars 76 forks source link

Pin to major version but not to minor or patch. #259

Closed feanil closed 4 years ago

feanil commented 5 years ago

Since this gets pulled into setup.py people who install this client into the same venv as others are limited to only these versions. Be more flexible here without losing the value of pinning.

Require urllib3>1.24.2 because older versions have a security vulnerability.

feanil commented 5 years ago

It looks like the tests are failing for some unrelated reason. The test runs seem to be passing but then failing in a shell script that runs after the test run in some cases.

diegobz commented 4 years ago

Thank for the patch. I used it in a PR within our repo, so our CI setup can fully run the integration tests.

Closing this in favor or #273.