Just update urllib3 to take a security fix.

transifex / transifex-client

The Transifex command-line tool.

https://www.transifex.com/

GNU General Public License v2.0

135 stars 75 forks source link

Just update urllib3 to take a security fix. #260

Closed feanil closed 5 years ago

feanil commented 5 years ago

Looks like the tests pass but then there is a failure in the test script that is unclear. @rigaspapas @diegobz any insights on what's going on? This should just be a simple security update.

diegobz commented 5 years ago

Environment variables setup in CircleCI are not available when running a build for a PR from an external repo. AFAIK there is no good way around it besides opening a PR from a branch in transifex/transifex-client.

FYI @rigaspapas @mikegianno @dbendilas ^^

diegobz commented 5 years ago

Closing in favor of #261.