search

transifex / transifex-client

The Transifex command-line tool.
https://www.transifex.com/
GNU General Public License v2.0
135 stars 75 forks source link

Support Python 3.9 #303

Closed terencehonles closed 3 years ago

terencehonles commented 3 years ago

It's that time again (#266) :sweat_smile:

terencehonles commented 3 years ago

Looks like I need to update pyenv again too... I'll get to that later

terencehonles commented 3 years ago

Created PR to fix the docker image you are using randomknowledge/docker-pyenv-tox#5

candrikos commented 3 years ago

Hey there, the PR looks fine. Let's wait for the testing image to be approved and then re-run the tests before merging.

terencehonles commented 3 years ago

Hey there, the PR looks fine. Let's wait for the testing image to be approved and then re-run the tests before merging.

@candrikos it looks like there are some issues building the docker image as it's gotten a bit too big. I adjusted your circle CI script to update the installed pyenv and either use the Python version in the container or be able to build a newer version. I also made it forward compatible with the change we are looking at making in https://github.com/randomknowledge/docker-pyenv-tox/pull/6 / https://github.com/randomknowledge/docker-pyenv-tox/pull/7. I hope the adjustments to the circle CI script make sense and it's OK to build Python versions if needed.

patrys commented 3 years ago

Is official support the only reason to explicitly cap compatible Python versions at the package manager level? Capping on a minor version is only causing inconvenience to the community as we are forced to wait for this (purely cosmetic) change to be released. Could the "Python versions 3.10 and beyond are currently unsupported" message live in the README instead?

terencehonles commented 3 years ago

Is official support the only reason to explicitly cap compatible Python versions at the package manager level? Capping on a minor version is only causing inconvenience to the community as we are forced to wait for this (purely cosmetic) change to be released. Could the "Python versions 3.10 and beyond are currently unsupported" message live in the README instead?

We may want to track this comment outside this PR, but if we can get answers here that's fine with me.

Related to your question is the fact that the trove classifiers state Python >= 3.5, but the check is python_requires=">=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.* which is Python >= 3.4. I'm not sure if the lower bound should be adjusted and the upper bound be removed.

I'm also not sure how long Transifex expects to support Python 2, and if that's dropped it could be more simply stated as python_requires=">=3.5"

My final comment is Python 3.5 has reached EoL https://www.python.org/dev/peps/pep-0478/#id4 so I'm not sure if that should be dropped from the trove classifiers. Removing the check from the python_requires section will allow people to be able to install and potentially use the package, but support would not be guaranteed.

All of this is in line with @patrys 's comment

candrikos commented 3 years ago

@terencehonles can you please add a dummy commit squash and force push to retrigger the appveyor testing service? It seems to have stuck.

terencehonles commented 3 years ago

@terencehonles can you please add a dummy commit squash and force push to retrigger the appveyor testing service? It seems to have stuck.

Done

terencehonles commented 3 years ago

@terencehonles can you please add a dummy commit squash and force push to retrigger the appveyor testing service? It seems to have stuck.

@candrikos I think this is actually the same issue as last time https://github.com/transifex/transifex-client/pull/266#issuecomment-565380187 and you may need to copy my branch to the transifex repository and create a new PR to merge it in.

See: https://circleci.com/blog/triggering-trusted-ci-jobs-on-untrusted-forks/

Diontsoumas commented 3 years ago

Closed in favor of https://github.com/transifex/transifex-client/pull/306