search

transifex / transifex-client

The Transifex command-line tool.
https://www.transifex.com/
GNU General Public License v2.0
136 stars 76 forks source link

Support all Python versions above 3.4 #330

Closed strokirk closed 1 year ago

strokirk commented 3 years ago

Hi,

Python 3.10 is released, and the only thing preventing transifex-client from using it is the setup.py configuration.

For ease of review I just performed the same changes as https://github.com/transifex/transifex-client/pull/306 .

If it seems reasonable, I'd be glad to update the python_requires line to allow all Python versions above 3.4 instead (so I can experiment with 3.11 easier 😊).

kaapstorm commented 3 years ago

I agree with the idea of dropping 3.11 as the max Python version in python_requires. If we're worried about breaking changes in Python, how about python_requires=">=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*,<4" instead?

strokirk commented 3 years ago

I've updated the PR to simply allow all modern Python 3 subversions.

goapunk commented 2 years ago

any chance that this will get merged soon? :) It's quite a blocker since many distros ship with python 3.10

strokirk commented 2 years ago

Ping @kostasgian , anything I need to change for this PR to be merged?

kostasgian commented 2 years ago

Hi @strokirk , nice work! Please consider squashing the commits and please check of the failed checks!

You need to know though, that this client will soon be deprecated and will be replaced by the new tx client.

strokirk commented 2 years ago

Hi @kostasgian , thanks for the response! I've rebased on the latest master.

Is the new tx client out of alpha? Congratulations in that case!

For some reason the tests fail on Python 2.7.

ERROR:   py27-vanilla: InvocationError for command /root/transifex/transifex-client/.tox/py27-vanilla/bin/pip install -U --exists-action w .tox/.tmp/package/1/transifex-client-0.14.4.zip (exited with code 1)
ERROR:   py27-pyopenssl: InvocationError for command /root/transifex/transifex-client/.tox/py27-pyopenssl/bin/pip install -U --exists-action w .tox/.tmp/package/1/transifex-client-0.14.4.zip (exited with code 1)
kostasgian commented 2 years ago

Hi @strokirk , we removed the alpha label from the new tx client and we are promoting it now as the default client for transifex.

Now as far as it concerns the test fails I need to find some time first in order to take a look...

ThiefMaster commented 2 years ago

Can this PLEASE be merged and released? It's been more than half a year, and transifex-client STILL fails to install on 3.10...

ThiefMaster commented 2 years ago

OK, looks like there's a new CLI. Being able to install the old one with pip as part of the dev requirements was pretty convenient... Maybe archive the repo if this one is dead?

strokirk commented 2 years ago

@ThiefMaster Just a heads up that the new CLI is quite a bit slower, and hard to install. So it might be wise to invest in automating the tx runs in a CI actions or something similar.

Our company is working on an asdf plugin and Github Action to simplify installation, I'll post it here once it's up!