transistorsoft / cordova-background-geolocation-firebase

Firebase Adapter for Cordova Background Geolocation
MIT License
7 stars 5 forks source link

Fix License key issues with build automation #14

Closed servicesoftuk closed 4 years ago

servicesoftuk commented 4 years ago

We use Devops to build our android APK's and we build for 3 different environments (dev, beta, live). Each env has it's own license key so I needed to be able to change it during the build process, there was an issue with the plugin adding a default meta-data element for com.transistorsoft.firebaseproxy.license to androidmanifest.xml whenever the platform was added. I could not use the cordova config.xml config-file facility to add the license key as it caused a duplicate issue as one was already added by the plugin. I decided to remove the default from the plugin so it now works in the same way as the cordova-background-geolocation plugin. I also updated the cordova-support-google-services dependency to 1.4.0 as 1.3.1 was out of date.

christocracy commented 4 years ago

Looks good. Thanks, I forgot about this one.

christocracy commented 4 years ago

0.2.1 is released.