transistorsoft / react-native-background-geolocation

Sophisticated, battery-conscious background-geolocation with motion-detection
http://shop.transistorsoft.com/pages/react-native-background-geolocation
MIT License
2.61k stars 427 forks source link

Polgon Geofence licence can't be applied via Expo config plugin #2085

Closed vonkanehoffen closed 1 week ago

vonkanehoffen commented 1 month ago

Your Environment

Expected Behavior

When I buy a licence for the polygon geofence add-on I should be able to apply it via the Expo config plugin

Actual Behavior

I bought a licence, but the only fields available in the plugin are licence and hmsLicence. Looking at the docs here it says the polygon add-on licence needs applying via AndroidManifest like:

<meta-data android:name="com.transistorsoft.locationmanager.polygon.license" android:value="YOUR_POLYGON_LICENCE_KEY_HERE" />

which is not possible to add if it's an Expo project using CNG. ...so for now we just have to create our own custom plugin? Or did we miss something?

Steps to Reproduce

  1. Buy licence
  2. Activate licence key
  3. Fail to find anywhere to put it ;-)

Context

Trying to enable polygon geofencing via the config plugin in an Expo app

Debug logs

Logs ``` PASTE_YOUR_LOGS_HERE ```
christocracy commented 1 month ago

Polygon Geofencing is a relatively new add-on. I'd neglected to implement Expo license support for it. I've just added it now.

See Expo Setup

You must use the version 4.16.4, published moments ago.

alex-trofimov commented 1 month ago

Polygon Geofencing is a relatively new add-on. I'd neglected to implement Expo license support for it. I've just added it now.

See Expo Setup

You must use the version 4.16.4, published moments ago.

I think it might be relevant to this: using 4.16.4 without a polygon geofencing license causes a LICENSE VALIDATION FAILURE (com.transistorsoft.locationmanager.polygon.license: UNDEFINED) prompt to be displayed. We aren't using that plugin in our app 🤔

github-actions[bot] commented 2 weeks ago

This issue is stale because it has been open for 30 days with no activity.

sirusbaladi commented 1 week ago

Polygon Geofencing is a relatively new add-on. I'd neglected to implement Expo license support for it. I've just added it now. See Expo Setup You must use the version 4.16.4, published moments ago.

I think it might be relevant to this: using 4.16.4 without a polygon geofencing license causes a LICENSE VALIDATION FAILURE (com.transistorsoft.locationmanager.polygon.license: UNDEFINED) prompt to be displayed. We aren't using that plugin in our app 🤔

updates on this?

christocracy commented 1 week ago

See CHANGELOG.