Allow filtering by node type for node children

transition-zero / tz-client

A client repository for accessing FEO data programmatically.

https://docs.feo.transitionzero.org

Apache License 2.0

21 stars 4 forks source link

Allow filtering by node type for node children #144

Open jessLryan opened 3 months ago

jessLryan commented 3 months ago

Description

Solves issue #127

Checklist

[y] Dependencies install correctly in a clean environment and code executes;
[y] Test coverage extended; created tests fail without the change (if possible);
[y] All tests passing;
[y] Commits follow a type convention (e.g. https://gist.github.com/brianclements/841ea7bffdb01346392c#type);
[y] Extended the README, documentation and/or docstrings, if necessary;

vercel[bot] commented 3 months ago

@jessLryan is attempting to deploy a commit to the transition-zero Team on Vercel.

A member of the Team first needs to authorize it.

Lkruitwagen commented 3 months ago

Hi @jessLryan - thanks for the PR!

It might be helpful to have a chat about a few things in our design here.

One other change we should mention, is child nodes that are assets will no longer be returned as children. This might alleviate the need for child filtering per #127 .

Would you be open to getting on a call with us? would love to hear how you're using our client and platform!