[ENG-400] fix: relax timeout

transition-zero / tz-client

A client repository for accessing FEO data programmatically.

https://docs.feo.transitionzero.org

Apache License 2.0

21 stars 4 forks source link

[ENG-400] fix: relax timeout #73

Closed a-cass closed 10 months ago

a-cass commented 10 months ago

Description

Set timeout to 20s to allow for slower Node.geometry repsonse.

Checklist

[x] Dependencies install correctly in a clean environment and code executes;
[x] Test coverage extended; created tests fail without the change (if possible);
[x] All tests passing;
[x] Commits follow a type convention (e.g. https://gist.github.com/brianclements/841ea7bffdb01346392c#type);
[x] Extended the README, documentation and/or docstrings, if necessary;

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
feo-client	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 29, 2023 0:22am

notion-workspace[bot] commented 10 months ago

FEO-Client: Relax timeout

joconnor-ecaa commented 10 months ago

@a-cass @Lkruitwagen These geometries that are timing out at 10s on colab might take significantly longer for someone on the other side of the world with a shitty connection. Maybe we should have global config so such a user can set this much higher.

and / or set it to like 60s to err further on the side of stuff not breaking

a-cass commented 10 months ago

The DB side does not seem to be the bottleneck here e.g IDN takes ~3s to apply simplification. The result is a 2mb payload which seems reasonable to return within the 10s timeout. Will continue investigation.