transitive-bullshit / agentic

AI agent stdlib that works with any LLM and TypeScript AI SDK.
https://agentic.so
MIT License
16.22k stars 2.12k forks source link

switch tokenizer implementation with pure js and more compatible js-tiktoken #571

Closed masterkain closed 1 year ago

masterkain commented 1 year ago

closes https://github.com/transitive-bullshit/chatgpt-api/issues/570

socket-security[bot] commented 1 year ago

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
js-tiktoken@1.0.5 None +0 davidduong

🚮 Removed packages: @dqbd/tiktoken@1.0.7

masterkain commented 1 year ago

tested, works

BLipscomb commented 1 year ago

When will this get merged?

transitive-bullshit commented 1 year ago

Thanks @masterkain

It seems @dqbd has multiple version of his port, and I wasn't able to find the differences clearly documented anywhere. (@dqbd/tiktoken, js-tiktoken, and tiktoken). Langchainjs seems to be using js-tiktoken, so we'll go with that for now.

Would love for this to be clearer, though.