search

transitive-bullshit / check-links

Robustly checks an array of URLs for liveness. Extremely fast ⚡
MIT License
334 stars 10 forks source link

Pass options to `got` #5

Closed wooorm closed 5 years ago

wooorm commented 5 years ago

The docs mention:

opts object? Optional configuration options (any extra options are passed to got)

…but there is only code that mixes opts.headers with the default headers.

Based on the docs, remark-lint-no-dead-urls has gotOptions, but they’re not working (davidtheclark/remark-lint-no-dead-urls#15).

Can other options also be passed through to got?

transitive-bullshit commented 5 years ago

Yep; this looks like a bug. I'll have some time to address it likely Tuesday.

If anyone wants to submit a PR before then, feel free.

Thanks! 😄

transitive-bullshit commented 5 years ago

This should be fixed via https://github.com/transitive-bullshit/check-links/commit/6ed05365100adb9ee1b2a62d0a01b961408cb32a and released as a patch v1.1.8.

wooorm commented 5 years ago

Sweet, thanks! Closing as it’s probably done!