transitive-bullshit / ffmpeg-gl-transition

FFmpeg filter for applying GLSL transitions between video streams.
650 stars 126 forks source link

submit a patch to ffmpeg #1

Open tinybug opened 6 years ago

tinybug commented 6 years ago

This is a great idea, hope you could commit a patch to ffmpeg.

transitive-bullshit commented 6 years ago

Definitely on my todo list :)

transitive-bullshit commented 6 years ago

In the meantime, starring the repo will help gather support and give me momentum to take it to the next level of ffmpeg integration.

drlukacs commented 6 years ago

@transitive-bullshit What do you mean by "next level"?

What you have is already great, and the development could (and probably should) continue as part of the ffmpeg source.

transitive-bullshit commented 6 years ago

Submitting a patch to ffmpeg should be easy, but I'm expecting there to be some changes they'll want like removing glew and glfw in favor of sdl which I think ffmpeg uses in some other places.

I've signed up for the ffmpeg-devel mailing list awhile ago but haven't heard back.... really wish I could just submit a PR like most open source projects :sigh:

Cinerar commented 6 years ago

Plz push it to ffmpeg source, i understand that it is not so easy, but you work is very usefull.

cyanreg commented 4 years ago

Just an FYI, ffmpeg 4.3 got Vulkan filtering support, along with linking to libglslang to allow GLSL to be compiled during runtime. If someone is up for writing something upstreamable, the framework's done, and I can give some help on how to use it. OpenGL filters aren't really acceptable for inclusion since they have global state, and our API users would be somewhat extremely unhappy if we were to break theirs.

Cinerar commented 4 years ago

https://trac.ffmpeg.org/wiki/Xfade

121786404 commented 3 years ago

https://trac.ffmpeg.org/wiki/Xfade

Xfade is ffmpeg-gl-transition official patch?