search

transitive-bullshit / ffmpeg-gl-transition

FFmpeg filter for applying GLSL transitions between video streams.
650 stars 126 forks source link

Fix distorted outputs by using correct padding when reading/writing gl image data. #29

Closed jviney closed 5 years ago

jviney commented 5 years ago

Fixes #7.

transitive-bullshit commented 5 years ago

This looks perfect @jviney -- thank you so much! 👍

Give me a day or so to test locally.

CoreTechie commented 5 years ago

Does this also fixes Issue #28 ? Issue with all resolutions (including 1920 x 1080) having 16:9 aspect ratio ? In 1920 x 1080, it seems the frames appears to be cropped at both the top and right edges.

transitive-bullshit commented 5 years ago

It should @CoreTechie. Please follow-up if you're still experiencing issues.

CoreTechie commented 5 years ago

This doesn't seem to address the issue of cropping at the top and right edges of the frame of dims 1920 x 1080. A few rows at the top edge and couple of columns on the right edge are getting clipped. Has it something to do with the Magnification or Minification filters while the image data is mapped onto the texture ?

glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR);

CoreTechie commented 5 years ago

Hi Travis (@transitive-bullshit ) - Could you reproduce the problem with 1920 x 1080. What could be the possible causes for the cross-faded picture being shrunk. Also it seems the picture is slightly vertically shifted down including clipping on both top and right edges. Thanks !

yukesh0505 commented 5 years ago

Hi, I have the same bug. For some aspect ratio, rendered video didn't produce actual transition some funky transition occurs. please give me some suggestions