search

transitive-bullshit / nextjs-notion-starter-kit

Deploy your own Notion-powered website in minutes with Next.js and Vercel.
https://transitivebullsh.it/nextjs-notion-starter-kit
MIT License
6.21k stars 5.25k forks source link

fix: Problem that Code block is not displayed if even one import fails. #506

Closed mosugi closed 1 year ago

mosugi commented 1 year ago

Description

Promise.all() in Code block fails if even one import process fails, resulting in https://github.com/transitive-bullshit/nextjs-notion-starter-kit/issues/477 The problem occurs.

By using Promise.allSettled(), the Code block will be displayed even if it partially fails.

Notion Test Page ID

https://transitive-bs.notion.site/Code-Blocks-0c322c33381c49bca5083a451c334c39

vercel[bot] commented 1 year ago

Someone is attempting to deploy a commit to the Saasify Team on Vercel.

A member of the Team first needs to authorize it.

deevus commented 1 year ago

@transitive-bullshit Is this repo still active? Could you add some maintainers?

deevus commented 1 year ago

@mosugi Thanks for this. I noticed the same problem and have cherry-picked your commit into my repo.