search

transitive-bullshit / nextjs-notion-starter-kit

Deploy your own Notion-powered website in minutes with Next.js and Vercel.
https://transitivebullsh.it/nextjs-notion-starter-kit
MIT License
6.28k stars 5.29k forks source link

ISR doesn't seem to work #638

Closed chandragie closed 2 weeks ago

chandragie commented 3 weeks ago

Description

I noticed that ISR does not work after deploying, I'm on Vercel.

The build logs however says it's active:

image

image

However, once the app is deployed, the changes in Notion never applied. I tried changing the revalidate value but no luck.

mabdullahabid commented 3 weeks ago

Same issue here

mabdullahabid commented 3 weeks ago

I was thinking maybe we could add a manual revalidate in order to trigger revalidation instead of having to deploy every time.

chandragie commented 3 weeks ago

I was thinking maybe we could add a manual revalidate in order to trigger revalidation instead of having to deploy every time.

did you get it working?

mabdullahabid commented 3 weeks ago

Yes, I feel like the issue is not with this repo. Its Vercel. I think for some odd reason the revalidate doesn't work on the free plans. It considers ISR pages as SSG and only rebuilds them at build time. When I deployed the same website on my own VPS, it seemed to revalidate correctly.

chandragie commented 3 weeks ago

Yes, I feel like the issue is not with this repo. Its Vercel. I think for some odd reason the revalidate doesn't work on the free plans. It considers ISR pages as SSG and only rebuilds them at build time. When I deployed the same website on my own VPS, it seemed to revalidate correctly.

What? Really? I must have missed the updates. ISR seems supported in free plan in my first Next project in 2022. On Vercel, I always get the 500 error complaining about sharp packages. Duh

chandragie commented 2 weeks ago

@mabdullahabid it's working now. So, apparently ISR didn't work because of sharp error on Vercel. Fixed it and now everything including ISR works. Here how I solved the sharp problem: https://github.com/transitive-bullshit/nextjs-notion-starter-kit/issues/618#issuecomment-2442119220

Closing this issue now.