transitive-bullshit / nextjs-notion-starter-kit

Deploy your own Notion-powered website in minutes with Next.js and Vercel.
https://transitivebullsh.it/nextjs-notion-starter-kit
MIT License
6.28k stars 5.29k forks source link

@react-icons/all-files hasn't been updated in long time. Replace it with react-icons #642

Open onnimonni opened 2 weeks ago

onnimonni commented 2 weeks ago

Context

This fixes the annoying DeprecationWarning and should allow us to use all of the new icons which are not available in @react-icons/all-files.

$ pnpm dev

> nextjs-notion-starter-kit@2.0.0 dev /Users/onnimonni/Projects/nextjs-notion-starter-kit
> next dev

   ▲ Next.js 15.0.2
   - Local:        http://localhost:3000

 ✓ Starting...
 ✓ Ready in 3.2s
 ○ Compiling / ...
 ✓ Compiled / in 1286ms (759 modules)
(node:79829) [DEP0128] DeprecationWarning: Invalid 'main' field in '/Users/onnimonni/Projects/nextjs-notion-starter-kit/node_modules/@react-icons/all-files/package.json' of 'lib'. Please either fix that or report it to the module author
(Use `node --trace-deprecation ...` to show where the warning was created)

Screenshots

Icons are rendering perfectly even after this change:

image
vercel[bot] commented 2 weeks ago

@onnimonni is attempting to deploy a commit to the Saasify Team on Vercel.

A member of the Team first needs to authorize it.

socket-security[bot] commented 2 weeks ago

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@react-icons/all-files@4.1.0

View full report↗︎