Open jonathanrobie opened 3 years ago
Jonathan
I did some Perl Grep searches and uncovered some incorrect mappings. 1Sam and 2Sam references all have correct mapping. Both 1Kgs and 2Kgs references have several incorrect mappings for each. 1Kgs was incorrectly being mapped to I Ki and 2Kgs was incorrectly being mapped to II Ki. I've attached two files, one for each of the incorrect Kgs mappings. Each of these files has the lines of the mismatch, preceded by the line number in the Abbott-smith.tei.xml file. Each of these files shows the mismatches only for its book of Kings.
Dave
On Thu, Sep 2, 2021 at 3:35 PM Jonathan Robie @.***> wrote:
It would be helpful to have someone check all the references to 1 Kings, 2 Kings, 3 Kings, and 4 Kings. The following shows how book names map from the LXX into the book names we know in the English-speaking world:
LXX 1 Kings => English 1 Samuel LXX 2 Kings => English 2 Samuel LXX 3 Kings => English 1 Kings LXX 4 Kings => English 2 Kings
Spot checking, many of these have been correctly linked. Someone "corrected" a reference from III Kings to II Kings. III Kings is the LXX way to say 1 Kings. This is now correct, I believe:
3 Abia, Abijah .Son of Rehoboam (III Ki 14:1): Mt 1:7. A priest of the line of Eleazar (I Ch 24:3, 10): Lk 1:5.† Some entries have been fixed correctly, here's an example where I Kings is correctly mapped onto 2 Samuel:
7 [in LXX: II Ki 22:12 (= Ps 17 (18):11 שׁחק ), Wi8;]in Hom., Hes., the lower air which surrounds the earth, as opp. to the purer αἰθήρ of the higher regions; generally,air (MM,VGT , s.v.): Ac 22:23, I Th 4:17, Re 9:2 16:17; of the air as the realm of demons, Eph 2:2;ἀ. δέρειν , of striving to no purpose, I Co 9:26;εἰς ἀ. λαλεῖν , of speaking without effect, not being understood, I Co 14:9.†— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/translatable-exegetical-tools/Abbott-Smith/issues/107, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEACF3ZIE3QI4AGVB264DADT77NX3ANCNFSM5DJ5AOOQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
18180:
20957:1390:
Thanks, Dave! I'll see about making these changes in my repo and publishing a pull request. Unless you prefer to do that?
I think I have opened a can of worms. With a view to reviewing references more systematically, I created mappings both ways between the Abbott-Smith abbreviations and the OSIS ID abbreviations, and the first thing I did was to look for transcribed references that didn't match the A-S abbreviations, which means either we transcribed incorrectly or the original Abbott-Smith was inconsistent. Here are the results:
(venv3) cbearden@melanchthon:~/projects/Abbott-Smith-mine/scratch$ python refs.py | sort | uniq -c | sort -nr
131 I Jn
21 Mac
10 Jn
4 Ha
3 Phi
2 Luke
1 Su
1 Lu
1 Isa
1 II Tim
1 II Jn
1 Heb
1 Gal
1 Act
The great majority are 1 Jn
, which should be 1 Jo
. But until these are corrected, a comparison between the OSIS book abbrev & the A-S book abbrev will not give reliable results. I think this will belong an a new issue, since it goes beyond the scope of I-IV Kings.
Charles
You go ahead and do the mods and pr. You’ve open up a question for me and our UGL syntax checker that I wrote. Is it verifying the correct spellings on both sides of the references? I am pretty certain that it does, since our syntax requirements doc has a table that specifies the forms of both terms.
Dave
On Mon, Sep 6, 2021 at 5:21 PM Charles Bearden @.***> wrote:
Thanks, Dave! I'll see about making these changes in my repo and publishing a pull request. Unless you prefer to do that?
I think I have opened a can of worms. With a view to reviewing references more systematically, I created mappings both ways between the Abbott-Smith abbreviations and the OSIS ID abbreviations, and the first thing I did was to look for transcribed references that didn't match the A-S abbreviations, which means either we transcribed incorrectly or the original Abbott-Smith was inconsistent. Here are the results:
(venv3) @.***:~/projects/Abbott-Smith-mine/scratch$ python refs.py | sort | uniq -c | sort -nr 131 I Jn 21 Mac 10 Jn 4 Ha 3 Phi 2 Luke 1 Su 1 Lu 1 Isa 1 II Tim 1 II Jn 1 Heb 1 Gal 1 Act
The great majority are 1 Jn, which should be 1 Jo. But until these are corrected, a comparison between the OSIS book abbrev & the A-S book abbrev will not give reliable results. I think this will belong an a new issue, since it goes beyond the scope of I-IV Kings.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/translatable-exegetical-tools/Abbott-Smith/issues/107#issuecomment-913872909, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEACF3ZIJW2N5MTZAVMPCH3UAU5G5ANCNFSM5DJ5AOOQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
--
Hi Dave,
You go ahead and do the mods and pr.
Will do.
As for the abbreviations of the book names I used for checking, I have attached the mapping that I constructed in YAML syntax. The AS_to_OSIS mapping is from the Abbott-Smith abbreviations as specified on p. xii of the lexicon. I took the OSIS abbreviations from Appendix C of the OSIS 2.1 User Manual which can be found here. The OSIS_to_AS maps the OSIS abbreviations back to the Abbott-Smith ones. Just in case those are useful to you.
All the best, Chuck
Charles
The reference below points to our UGL requirements document and the section on name mapping. There are two sections, regular form and then LXX.
DAVE
https://ugl-info.readthedocs.io/en/latest/abbreviations.html#usfm-names
On Mon, Sep 6, 2021 at 8:12 PM Charles Bearden @.***> wrote:
Hi Dave,
You go ahead and do the mods and pr.
Will do.
As for the abbreviations of the book names I used for checking, I have attached the mapping that I constructed in YAML syntax. The AS_to_OSIS mapping is from the Abbott-Smith abbreviations as specified on p. xii of the lexicon. I took the OSIS abbreviations from Appendix C of the OSIS 2.1 User Manual which can be found here https://ebible.org/osis/OSIS2_1UserManual_06March2006_-_with_O'Donnell_edits.PDF. The OSIS_to_AS maps the OSIS abbreviations back to the Abbott-Smith ones. Just in case those are useful to you.
All the best, Chuck
abbrevs.yaml.txt https://github.com/translatable-exegetical-tools/Abbott-Smith/files/7118222/abbrevs.yaml.txt
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/translatable-exegetical-tools/Abbott-Smith/issues/107#issuecomment-913922079, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEACF3ZWULMDXTAE7DSZ3DLUAVRINANCNFSM5DJ5AOOQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
--
It would be helpful to have someone check all the references to 1 Kings, 2 Kings, 3 Kings, and 4 Kings. The following shows how book names map from the LXX into the book names we know in the English-speaking world:
LXX 1 Kings => English 1 Samuel LXX 2 Kings => English 2 Samuel LXX 3 Kings => English 1 Kings LXX 4 Kings => English 2 Kings
Spot checking, many of these have been correctly linked. Someone "corrected" a reference from III Kings to II Kings. III Kings is the LXX way to say 1 Kings. This is now correct, I believe:
Some entries have been fixed correctly, here's an example where I Kings is correctly mapped onto 2 Samuel: