search

translatable-exegetical-tools / Abbott-Smith

Abbott-Smith's Manual Greek Lexicon
31 stars 19 forks source link

Fix outstanding issues #112

Closed mrgreekgeek closed 4 months ago

mrgreekgeek commented 6 months ago

Thank you so much to all those who have put in the work to get this repo to where it is today!

Does this repo represent the lastest/greatest work on Abbot-Smith, or is there something newer?

It looks like nothing has happened here for a few years, and there are some issues that need to be dealt with. I'm working on an easy-to-use searchable online Greek lexicon app based on this data, so I'd love to see any known errors corrected before I make the app go live. If I create a pull request to fix at least the simple typo issues, will someone be around here to merge it? @jonathanrobie @destatez looks like you guys were the last ones making changes. :)

destatez commented 6 months ago

You’all

It’s been so long since I’ve done anything with github that I’m not how to do that merge. I’m concerned about the state of my github, see screenshot below. Should I do anything to my repo before I would do your upcoming merge? I’m retired twice, Rockwell Collins and then Wycliffe Associates. I guess I would have the access rights to do that merge.

Dave

On Sat, Feb 3, 2024 at 3:42 PM mrgreekgeek @.***> wrote:

Thank you so much to all those who have put in the work to get this repo to where it is today!

Does this repo represent the lastest/greatest work on Abbot-Smith, or is there something newer?

It looks like nothing has happened here for a few years, and there are some issues that need to be dealt with. I'm working on an easy-to-use searchable online Greek lexicon app based on this data, so I'd love to see any known errors corrected before I make the app go live. If I create a pull request to fix at least the simple typo issues, will someone be around here to merge it? @jonathanrobie https://github.com/jonathanrobie @destatez https://github.com/destatez looks like you guys were the last ones making changes. :)

— Reply to this email directly, view it on GitHub https://github.com/translatable-exegetical-tools/Abbott-Smith/issues/112, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEACF32P5JGVJH5ZSMBUJP3YR24LRAVCNFSM6AAAAABCYLAVW6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGEYTMNZQGI4DINY . You are receiving this because you were mentioned.Message ID: @.***>

jonathanrobie commented 6 months ago

I can review, and merge if appropriate.

Jonathan

On Sun, Feb 4, 2024, 14:10 David Statezni @.***> wrote:

You’all

It’s been so long since I’ve done anything with github that I’m not how to do that merge. I’m concerned about the state of my github, see screenshot below. Should I do anything to my repo before I would do your upcoming merge? I’m retired twice, Rockwell Collins and then Wycliffe Associates. I guess I would have the access rights to do that merge.

Dave

On Sat, Feb 3, 2024 at 3:42 PM mrgreekgeek @.***> wrote:

Thank you so much to all those who have put in the work to get this repo to where it is today!

Does this repo represent the lastest/greatest work on Abbot-Smith, or is there something newer?

It looks like nothing has happened here for a few years, and there are some issues that need to be dealt with. I'm working on an easy-to-use searchable online Greek lexicon app based on this data, so I'd love to see any known errors corrected before I make the app go live. If I create a pull request to fix at least the simple typo issues, will someone be around here to merge it? @jonathanrobie https://github.com/jonathanrobie @destatez https://github.com/destatez looks like you guys were the last ones making changes. :)

— Reply to this email directly, view it on GitHub < https://github.com/translatable-exegetical-tools/Abbott-Smith/issues/112>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/AEACF32P5JGVJH5ZSMBUJP3YR24LRAVCNFSM6AAAAABCYLAVW6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGEYTMNZQGI4DINY>

. You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/translatable-exegetical-tools/Abbott-Smith/issues/112#issuecomment-1925884757, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANPTPN3766OF5EDCYEHZYTYR7MIVAVCNFSM6AAAAABCYLAVW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRVHA4DINZVG4 . You are receiving this because you were mentioned.Message ID: @.*** com>

jonathanrobie commented 6 months ago

I’m concerned about the state of my github, see screenshot below.

I cannot see your screenshot. If you send it to me, I could make sure I sort out any problems you are aware of. I would also like to make sure that I consult with @cbeardon, who has done a lot of work on this repository.

I’m retired twice, Rockwell Collins and then Wycliffe Associates.

If you would like to pass on primary responsibility for the repository, I am happy to take over.

destatez commented 6 months ago

It helps to attach an attachment

On Mon, Feb 5, 2024 at 5:55 AM Jonathan Robie @.***> wrote:

I’m concerned about the state of my github, see screenshot below.

I cannot see your screenshot. If you send it to me, I could make sure I sort out any problems you are aware of. I would also like to make sure that I consult with @cbeardon, who has done a lot of work on this repository.

I’m retired twice, Rockwell Collins and then Wycliffe Associates.

If you would like to pass on primary responsibility for the repository, I am happy to take over.

— Reply to this email directly, view it on GitHub https://github.com/translatable-exegetical-tools/Abbott-Smith/issues/112#issuecomment-1926937691, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEACF3ZZDDWMILDXMUYGCN3YSDJFTAVCNFSM6AAAAABCYLAVW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRWHEZTONRZGE . You are receiving this because you were mentioned.Message ID: @.*** com>

destatez commented 6 months ago

The screenshot that a attached on both ‘sends’ didn’t seem to work. I’ve attached a PDF of it

Dave

On Sat, Feb 3, 2024 at 3:42 PM mrgreekgeek @.***> wrote:

Thank you so much to all those who have put in the work to get this repo to where it is today!

Does this repo represent the lastest/greatest work on Abbot-Smith, or is there something newer?

It looks like nothing has happened here for a few years, and there are some issues that need to be dealt with. I'm working on an easy-to-use searchable online Greek lexicon app based on this data, so I'd love to see any known errors corrected before I make the app go live. If I create a pull request to fix at least the simple typo issues, will someone be around here to merge it? @jonathanrobie https://github.com/jonathanrobie @destatez https://github.com/destatez looks like you guys were the last ones making changes. :)

— Reply to this email directly, view it on GitHub https://github.com/translatable-exegetical-tools/Abbott-Smith/issues/112, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEACF32P5JGVJH5ZSMBUJP3YR24LRAVCNFSM6AAAAABCYLAVW6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGEYTMNZQGI4DINY . You are receiving this because you were mentioned.Message ID: @.***>

mrgreekgeek commented 4 months ago

Any progress on this? @destatez your attachments are not showing up here on Github. I'll be happy to help contribute fixes to any open issues that haven't already been resolved. Please let me know what I can do to help. :)

destatez commented 4 months ago

I guess it’s Oops. From previous conversations I didn’t think that I had any work to do concerning this. Where have I dropped the ball?

Dave

On Sat, Apr 13, 2024 at 1:41 PM mrgreekgeek @.***> wrote:

Any progress on this? @destatez https://github.com/destatez your attachments are not showing up here on Github. I'll be happy to help contribute fixes to any open issues that haven't already been resolved. Please let me know what I can do to help. :)

— Reply to this email directly, view it on GitHub https://github.com/translatable-exegetical-tools/Abbott-Smith/issues/112#issuecomment-2053727835, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEACF334W2J52SQNJY6E4GTY5F34HAVCNFSM6AAAAABCYLAVW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJTG4ZDOOBTGU . You are receiving this because you were mentioned.Message ID: @.*** com>

mrgreekgeek commented 4 months ago

I guess it’s Oops. From previous conversations I didn’t think that I had any work to do concerning this. Where have I dropped the ball? Dave

OK, no problem. I wasn't sure if maybe you had some fixes outstanding that hadn't been uploaded/committed yet. If not, then I'll see about trying to contribute a pull request to fix at least the simplest issues and hopefully Jonathan can approve them.

jonathanrobie commented 4 months ago

I'll review the pull request when I see it.

Jonathan

On Sat, Apr 13, 2024, 17:14 mrgreekgeek @.***> wrote:

I guess it’s Oops. From previous conversations I didn’t think that I had any work to do concerning this. Where have I dropped the ball? Dave

OK, no problem. I wasn't sure if maybe you had some fixes outstanding that hadn't been uploaded/committed yet. If not, then I'll see about trying to contribute a pull request to fix at least the simplest issues and hopefully Jonathan can approve them.

— Reply to this email directly, view it on GitHub https://github.com/translatable-exegetical-tools/Abbott-Smith/issues/112#issuecomment-2053763048, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANPTPOY4X4RYKFPBJAUIKDY5GN47AVCNFSM6AAAAABCYLAVW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJTG43DGMBUHA . You are receiving this because you were mentioned.Message ID: @.*** com>

mrgreekgeek commented 4 months ago

Thanks @jonathanrobie I just submitted a PR.

mrgreekgeek commented 4 months ago

Thanks for the prompt merge, @jonathanrobie!

The abbott-smith.tei_lemma.xml file doesn't get automatically updated, does it? That's the one I was using for my app... I think if we could take care of #91 and #102 then that would sort of get rid of the need for the lemma file, and I could just use the main file for my app. I'm willing to make the changes if some agreement can be reached on what should be done.