translate-tools / linguist

Translate web pages, highlighted text, Netflix subtitles, private messages, speak the translated text, and save important translations to your personal dictionary to learn words even offline
https://linguister.io
BSD 3-Clause "New" or "Revised" License
706 stars 24 forks source link

Option to show original text and translated both in one popup #380

Open vitonsky opened 1 year ago

vitonsky commented 1 year ago

Although this is a bug, I noticed that it is very useful for language learning. Normally I translate an english page to the language I am learning and read it comparing with the popup (original English).

With this bug I can first read the original sentence in English and then in the language I am learning. This speeds up because I don't need to go up and down between page content and popup.

So maybe this can be implemented as an "inline translation" option if you think other language learners would benefit from it too (and if it is not much effort for you). For example in this case translated text may be bold/different color to differentiate and easy skipping.

By the way, many thanks for this cool extension.

Originally posted by @offset-torque in https://github.com/translate-tools/linguist/issues/378#issuecomment-1625153359

offset-torque commented 1 year ago

Thanks for opening an issue for this. I want to clarify myself to prevent a misunderstanding because I wasn't referring to popup. Let me explain with an example:

Assume this is the original page:

This is an original article in English. It contains sentences and paragraphs.

And this is the translated page according to my idea:

This is an original article in English. Este es un artículo original en inglés. It contains sentences and paragraphs. Contiene oraciones y párrafos.

Advantages:

vitonsky commented 1 year ago

We can't to modify web page structure, because it will lead us to unexpected behavior.

But we can implement this behavior for translation selected text and maybe for translate entered text in extension popup. Is it will useful for you?

If you still needs some improvements on the page, you can suggest solutions, but consider that we must never change document structure to add or remove some elements on web page. This behavior will just broke most of web sites.

offset-torque commented 1 year ago

I understand. Popup is perfectly ok then.