search

translate / pootle

Online translation tool
http://pootle.translatehouse.org
GNU General Public License v3.0
1.49k stars 287 forks source link

Author of suggestions only displayed if you have reviewer access #1358

Closed dupuy closed 14 years ago

dupuy commented 14 years ago

Cris anderson861@gmail.com writes:

I'm in reviewing the suggestions, and I'd like to see which user submitted the suggestion like was possible with the old Pootle interface. Is this something I need to turn on, or is it not possible anymore?

I replied:

The Pootle 2.0.2 system used to translate Pootle itself shows the sources of suggestions; however, it seems that this is only displayed if you have permission to "review suggestions" (i.e. accept/reject them).

There doesn't seem to be any inherent reason for this information to be suppressed - it would be useful to anyone who is looking at suggestions to see who added them.

friedelwolff commented 14 years ago

Thank you for reporting this. I think we should try to do this on trunk and the 2.0 branch in case we release another 2.0.x bugfix.

transl8bzimport commented 14 years ago

Originally posted by Chris Leonard:

I have done some further investigation and it looks like many of the suggestions on the lang-mn etoys project are from a user:versionmerge. This is not a registered Pootle user on our server, so I have a theory that these are suggestions that pre-existed the migration from Pootle 1.2 to Pootle 2.0 (Sugar Labs / OLPC server was migrated recently). It is possible that the migration process lost some information about who made the suggestions, and the suggestor name has been substituted with user:versionmerge during the migration process.

I'm not sure of this, but it is my current working theory. I can see that on other projects, suggestions made since the migration do properly show the suggesting users identity.

alaaosh commented 14 years ago

suggestions made by versionmerge are the result of merge conflicts on version control updates.

in 2.0 the way we format suggestions changed that's why usernames in old suggestions are not showing up.

how important is it to support the old style?

transl8bzimport commented 14 years ago

Originally posted by Chris Leonard:

IMHO, it is not critical to support the old style across a version migration. The important thing is that new suggestions will display username as expected, and this has been confirmed to be the case. The original reporter (Cris anderson861@gmail.com) is satisfied with this explanation as long as the suggesting user displays going forward.

It might make a good note for the release notes to mention that resolving suggestions prior to a migration will minimize the impact of this.