translate / pootle

Online translation tool
http://pootle.translatehouse.org
GNU General Public License v3.0
1.49k stars 287 forks source link

Need a last modified datestamp on translation projects #2964

Closed dwaynebailey closed 11 years ago

dwaynebailey commented 11 years ago

Depends on:

If you are viewing things at a translation project level you have no idea when the translations where changed.

I'd propose that we add the top level github like approach to appear below the "File and Subfolders" heading:

[Gravatar] $user translated|suggested N hours ago

iafan commented 11 years ago

I like the idea of providing the flow of changes. I'd also link to particular units and make gravatars, usernames clickable:

[Gravatar] $user translated|suggested _somestring N hours ago

transl8bzimport commented 11 years ago

Commit pushed to master at https://github.com/translate/pootle

https://github.com/translate/pootle/commit/8ad8d649c95c6b8a10a1706d487aa05d7f4fdf98 Add a GitHub-like message for latest activity on a given TP

Fixes bug #2964

iafan commented 11 years ago

I just looked at the final result, and the UI doesn't feel quality enough for the production. See http://imgur.com/kg7aJtU as a reference for the current state of the UI. So I'm reopening the case and will provide the possible UI improvements below.

1) The placement of this UI feature is odd: it is now located right after the 'Files and folders' section. Why is that? I would suggest creating a separate block on the right hand side of the overview page (below the 'Actions' block), call it "Latest activity" and show, say, 10 most recent activity entries there, not just a single one.

2) It doesn't make sense to use unit IDs to link to units here (i.e. "string 29" tells nothing to actual translators or managers until they clickon it). Instead, we need to provide the actual source string there. Lengthy strings need to be trimmed to, say, 60 characters with ellipsis appended.

3) "A week ago" or any other text there needs not to be capitalized.

4) "sent translation for" is probably be better rephrased as "submitted translation for" (or "suggested translation for", depending on the action) to align with Pootle's terminology.

Having said that, I do think that this feature has a big potential and just needs some more love to look perfect and really useful.

unho commented 11 years ago

(In reply to Igor Afanasyev from BZ-IMPORT::comment #3)

I just looked at the final result, and the UI doesn't feel quality enough for the production. See http://imgur.com/kg7aJtU as a reference for the current state of the UI. So I'm reopening the case and will provide the possible UI improvements below.

1) The placement of this UI feature is odd: it is now located right after the 'Files and folders' section. Why is that? I would suggest creating a separate block on the right hand side of the overview page (below the 'Actions' block), call it "Latest activity" and show, say, 10 most recent activity entries there, not just a single one.

People asked for GitHub like message, so I added it before the files list. Doing as you suggest will turn this bug to be "show list of latest changes" instead of "show last change message".

I would prefer to create a new bug for this.

2) It doesn't make sense to use unit IDs to link to units here (i.e. "string 29" tells nothing to actual translators or managers until they clickon it). Instead, we need to provide the actual source string there. Lengthy strings need to be trimmed to, say, 60 characters with ellipsis appended.

I chose to keep it short.

3) "A week ago" or any other text there needs not to be capitalized.

This sounds that it would require changes that I am not sure if they are really necessary. I see this as two separate phrases, hence the capitalization.

4) "sent translation for" is probably be better rephrased as "submitted translation for" (or "suggested translation for", depending on the action) to align with Pootle's terminology.

Sounds reasonable.

Having said that, I do think that this feature has a big potential and just needs some more love to look perfect and really useful.

iafan commented 11 years ago

Let's hear from Dwayne then, since he was the one who opened the bug. I'm only concerned that the feature is obviously not ready and this blocks us from updating our translation server with other changes already implemented in the master branch (well, not strictly blocks, but I'm reluctant to publish things that are rough around the edges).

julen commented 11 years ago

Created attachment 933

A more integrated implementation

Taking into account the initial aim of this bug, the current implementation and the comments and concerns that have been raised, I have played in-browser to give this a more integrated look.

In the attached screenshot you'll see an example that tries to unify all of this. Don't worry about the displayed numbers, they're fake :)

For the latest activity entries I see Dwayne has filed bug #3022. That seems to align better with what's described in BZ-IMPORT::comment #3.

unho commented 11 years ago

(In reply to Julen Ruiz Aizpuru from BZ-IMPORT::comment #6)

Created attachment 933 [details] A more integrated implementation

Taking into account the initial aim of this bug, the current implementation and the comments and concerns that have been raised, I have played in-browser to give this a more integrated look.

Your proposal looks great.

unho commented 11 years ago

(In reply to Leandro Regueiro from BZ-IMPORT::comment #7)

(In reply to Julen Ruiz Aizpuru from BZ-IMPORT::comment #6)

Created attachment 933 [details] A more integrated implementation

Taking into account the initial aim of this bug, the current implementation and the comments and concerns that have been raised, I have played in-browser to give this a more integrated look.

Your proposal looks great.

Perhaps too much shadow around the table?

iafan commented 11 years ago

If 3022 is going to be implemented, this (current) implementation will be rendered obsolete, I suppose?

Though Julen's proposal is more clean in terms of look and feel, it still looks like a header for the list of the files/folders below, as if the last user has some ownership of these files or edited them all.

I know everybody now seems to be a fan of Github, but this particular UI concept is not the best thing to copy from Github, frankly speaking. If absolutely necessary, such status line would better be placed above the 'Files and Folders' header, in the overview/status area:

Project / folder / subfolder

This folder has 339 words, 100% of which are translated. Expand details Translation is complete

Last activity: [Gravatar] $user submitted|suggested _somestring N hours ago

Files and Subfolders ...

julen commented 11 years ago

(In reply to Igor Afanasyev from BZ-IMPORT::comment #9)

If 3022 is going to be implemented, this (current) implementation will be rendered obsolete, I suppose?

To some extent that's what I thought when I read about bug #3022. Note that the screenshot I attached had only the context of this bug in mind.

If a list of the recent changes should be displayed in this page, I would see them grouped on its own box, not tied together with the file/directory listing. Also, I accidentally removed the "Files and Subfolders" heading, and now that I realize of it, it feels redundant to me.

dwaynebailey commented 11 years ago

First off the mockup in comment 6 goes a long way to what I'd had in mind. I also noticed the missing title that Julen mentioned in comment 10. We'll be adding goals soon and I think we'd want to keep that at least in the short term so that we can tab to another view of the files.

(In reply to Igor Afanasyev from BZ-IMPORT::comment #9)

If 3022 is going to be implemented, this (current) implementation will be rendered obsolete, I suppose?

It might, though in my mind I'd think of a change stream as another view not in addition to the files.

Though Julen's proposal is more clean in terms of look and feel, it still looks like a header for the list of the files/folders below, as if the last user has some ownership of these files or edited them all.

I think if we don't lose the "Files" header we won't have that confusion. The colour can easily differentiate the roles.

I know everybody now seems to be a fan of Github, but this particular UI concept is not the best thing to copy from Github, frankly speaking. If absolutely necessary, such status line would better be placed above the 'Files and Folders' header, in the overview/status area:

Project / folder / subfolder

This folder has 339 words, 100% of which are translated. Expand details Translation is complete

Last activity: [Gravatar] $user submitted|suggested _somestring N hours ago

Files and Subfolders ...

From a use case my main goal was knowing who and when something was submitted. Either form achieves that goal. My concern is that it is lost in Igor's solution, though very much available.

I'd prefer to try Julen's suggested approach. But if it is a deal breaker I'm happy to use the above solution.

iafan commented 11 years ago

I just have one question still bugging me: why this status line should be rendered as a header of the files list? (besides the answer "because this is how it is done on Github")? Can anybody please give me any reasonable explanation from UX staindpoint?

dwaynebailey commented 11 years ago

(In reply to Igor Afanasyev from BZ-IMPORT::comment #12)

I just have one question still bugging me: why this status line should be rendered as a header of the files list? (besides the answer "because this is how it is done on Github")? Can anybody please give me any reasonable explanation from UX staindpoint?

It isn't a header, it is an info block. We have a File header already (and I see that perhaps expanding when we have other views). We have the sortable headers which I think are still clear. The info block and its placements is about creating the close association between the files that can be worked on and information about who made the last changes. For me the simple answer is that the information is close to where the action happens which is the files.

It is a note about the last action, as opposed to the more verbose statements above about actions that can be performed across the actions.

iafan commented 11 years ago

The info block and its placements is about creating the close association between the files that can be worked on and information about who made the last changes.

That's I think, where the problem is: you're creating an overly close association with a single most recent change and all files and subfolders, as if with this recent change the use has somehow altered alll those files. This is exactly the same problem the GitHub version is suffering for. You can commit a single line somewhere down a big project in GitHub, and any parent folder would show your status message tightly coupled with the entire folder structure, giving the same false impression that this latest change somehow affects all the nested content (which is not).

To avoid such false clues, the status message should better be tied with the top overview block, which describes the statistics on the current folder in general and gives guidance on possible actions. I put together a couple of mockups that illustrate this:

https://dl.dropboxusercontent.com/u/789693/Pootle/latest_action_1.png

and

https://dl.dropboxusercontent.com/u/789693/Pootle/latest_action_2.png

dwaynebailey commented 11 years ago

(In reply to Igor Afanasyev from BZ-IMPORT::comment #14)

The info block and its placements is about creating the close association between the files that can be worked on and information about who made the last changes.

That's I think, where the problem is: you're creating an overly close association with a single most recent change and all files and subfolders, as if with this recent change the use has somehow altered alll those files. This is exactly the same problem the GitHub version is suffering for. You can commit a single line somewhere down a big project in GitHub, and any parent folder would show your status message tightly coupled with the entire folder structure, giving the same false impression that this latest change somehow affects all the nested content (which is not).

To avoid such false clues, the status message should better be tied with the top overview block, which describes the statistics on the current folder in general and gives guidance on possible actions.

OK, convinced.

I put together a couple of mockups that illustrate this:

https://dl.dropboxusercontent.com/u/789693/Pootle/latest_action_1.png

and

https://dl.dropboxusercontent.com/u/789693/Pootle/latest_action_2.png

We'll go with the first one. Being horizontal it will work well with smaller screens as it limits the space it uses. The "Last activity" text might be redundant since the text is verbose and in its own visual block.

unho commented 11 years ago

Please check current status in http://bug2964-revisited.testing.locamotion.org/de/filezilla/

transl8bzimport commented 11 years ago

Commit pushed to master at https://github.com/translate/pootle

https://github.com/translate/pootle/commit/d5a92e17f530cd70b063438c3bc8f03860234748 Change the latest activity message shown inside a TP

Now the message:

Fixes bug #2964