search

translate / pootle

Online translation tool
http://pootle.translatehouse.org
GNU General Public License v3.0
1.49k stars 288 forks source link

Add `Continue suggesting` action button for suggesters #4628

Open ta2-1 opened 8 years ago

ta2-1 commented 8 years ago

For users with suggest rights only they are only shown the “Continue translation” button and links. This means that they are first taken to units that might already have suggestions. So we have units with many suggestions. Let's provide Continue suggesting action for those users and show them all untranslated units without suggestions instead. If all units have their suggestions we can show something like Add more suggestions.

iafan commented 8 years ago

+1 on this. Some comments / proposals:

Basically all volunteers having only suggestion rights will have these two action links in the toolbar:

Continue suggesting (N)        View all (M)

where N is the same number of words as in Continue translation action for translators (number of words in units that are either not translated or need review).

Clicking on Continue suggesting opens units sorted by this criteria:

  1. Number of suggestions for a unit
  2. priority (from vfolders, if any)
  3. pootle path
  4. unit index

The first criterion (Number of suggestions) means that units with no (zero) suggestions will be on top.

If one decides to choose any other sorting order in the UI (by e.g. date), its effect will be the same as with regular translation mode, which doesn't take number of suggestions into account.

ta2-1 commented 8 years ago

where N is the same number of words as in Continue translation action for translators (number of words in units that are either not translated or need review).

@iafan initially we thought to calculate untranslated units without suggestions. But your proposal looks promising to me. The only doubt: we will have to denormalise suggestion count to make sorting performant.

@dwaynebailey what do you think?

iafan commented 8 years ago

I actually proposed this sorting in the hope that it would be easier to implement. If this is going to be bad in terms of performance, then displaying just the units with no suggestions (and displaying their own stats) seems like a perfectly viable solution as well.

unho commented 8 years ago

Depending on the performance impact we might even have to display incomplete (fuzzy+untranslated) units. But displaying only the actions that can be performed shouldn't badly impact performance an is a great improvement.

dwaynebailey commented 8 years ago

@ta2-1 my initial thoughts:

  1. Initially sounds good to order by suggestion count
  2. Reservation is that the counts do not reduce
  3. If we need to denormalise to optimise, then no I don't think its a viable option
fernandogarcez commented 8 years ago

This is definitely a must have, really need that!

For now, is there a way for me to find that keys forcing a filter some how like: /translate.html?unitstates=fuzzy,untranslated,!hassugestion