translate / pootle

Online translation tool
http://pootle.translatehouse.org
GNU General Public License v3.0
1.49k stars 284 forks source link

Patch for configuring l10n path in the projects admin page #469

Closed transl8bzimport closed 14 years ago

transl8bzimport commented 15 years ago

Originally posted by Suresh:

Currently many projects are using commandline for configuring the access to an already existing l10n directory. This patch adds the ability to do so when configuring the project.

Add the absolute or relative path to po/xiff directory in the project WS using the field "Project L10N Directory" int the admin/projects.html. This will make the project available by configuring this under the Pootle/po directory of the installation.

Currently only the languages available in the system are reflected for the newly added project, addition of new languages can be worked in another patch.

transl8bzimport commented 15 years ago

Originally posted by Suresh:

Created attachment 165

Pootle patch for configring the project WS po directory directly in Pootle

Pl. check the patch and lemme know if this needs rework...

transl8bzimport commented 15 years ago

Originally posted by Suresh:

Created attachment 166

Modified patch sans 'import pdb'

Removed a pdb line which sneaked in...

transl8bzimport commented 15 years ago

Originally posted by Suresh:

Created attachment 167

Screenshot

A screenshot showing the changes projects page

transl8bzimport commented 15 years ago

Originally posted by Suresh:

Created attachment 168

Latest patch

The createl10npath is reworked. In a gist the code creates symlinks only if if the 'Project L10N Directory' is a valid directory and the projectcode is either not existing under Pootle/po or existing as a symlink.

If projectcode is existing as a non symlink directory/file under Pootle/po it won't touch it

transl8bzimport commented 15 years ago

Originally posted by Suresh:

Created attachment 169

patch

Another little change to make createl10npath fully comformant with the default behaviour, in case "Project L10N Directory" is left blank, then a directory projectdir will be created, else a symlink. The symlink can be later changed to point to the right path if the first attempt failed

alaaosh commented 14 years ago

since we now recommend deploying under apache we can't have stricter requirements for where data files may reside and what kind of permissions they can have.

we also use a save method that depends on creating new files and moving them over existing files to avoid file locking, but this method makes it difficult to work with data files residing in different file systems/partitions.

so symlinks are no longer encouraged and this feature doesn't make much sense anymore