XLIFF implementation expects certain states which might not match input XLIFF

[JohnnyKing94]

Steps to reproduce:

Pootle 2.8.0rc7 (and I think it was the same with rc6, i just didn't notice) syncs all my files in a wrong way when i run pootle sync_stores --force. This is my sample file which you can make tests with it: https://www.dropbox.com/s/o9lzdzbhojap37y/gamedata_1.xliff?dl=0 What you can see overall, it is a file with some target having in some cases the state attributes and in others not, same for trans-unit with the approved tags.

Where these attributes appear, it's related to the fact I was running Pootle 2.8.0rc3 and the tags always have been applied in all my files via pootle sync_stores --force, now no more!

Results (Expected/Actual):

In the previous version of Pootle the file was perfectly compiled showing all the cases where a string was in <target state="needs-translation"> and <trans-unit approved="no" when a string on Pootle was in needs-revision OR in <target state="translated"> and <trans-unit approved="yes" when a string was actually translated on Pootle.

For example the first string you see on the file is actually in need-revision state on my Pootle server (https://translate.tamrielunlimited.it/projects/gamedata/translate/gamedata_1.xliff#search=3427285-0-3&sfields=locations), but the file shows this, which it is wrong

      <trans-unit xml:space="preserve" id="3427285-0-3">
        <source>IDLE</source>
        <target>IDLE</target>
      </trans-unit>

The expected result must be

      <trans-unit xml:space="preserve" approved="no" id="3427285-0-3">
        <source>IDLE</source>
        <target state="needs-translation">IDLE</target>
      </trans-unit>

Basically the only diff is the two attributes missing...

Environment (i.e. 'pootle --version', DB, OS, Browser):

OS: Ubuntu Linux 16.04.1 LTS pootle --version: Pootle 2.8.0rc7 (Django 1.10.7, Translate Toolkit 2.2.4) MySQL: 5.7.19 Browser: Firefox 54.0.1

[dwaynebailey]

OK so I've tested an example file with every single possible permutation of state change. I then ran sync_stores with no other options. All operate as expected in 2.8.0rc7 except the following:

• Untranslated -> Fuzzy (with translation): we show translation but none of the states to indicate fuzzyness, it has no approved= and no state=
• Translated -> Untranslated: we untranslate, i.e. remove translation, but we're leaving the states for previous translation approved=yes state=translated
• Fuzzy -> Untranslated: target is untranslated but states are as before i.e. approved=no state=needs-translation

So summary for these examples:

1. The target is set correctly
2. The states remain as they were set previously

[JohnnyKing94]

@dwaynebailey, did you test it with the example i gave? If not, can you please do that... thx