translate / virtaal

Easy-to-use and powerful offline translation tool
https://virtaal.translatehouse.org
GNU General Public License v2.0
298 stars 57 forks source link

Checkmarks in QualityCheck selection with black background theme are invisible #1980

Open transl8bzimport opened 13 years ago

transl8bzimport commented 13 years ago

Version: 0.7.0

Originally posted by Joerg Toellner:

Hi TTK/Virtaal Team,

i am just noticed in Virtaal 0.7.1 the following problem when i use my black background theme. I am using the standard windows xp theme "Windows classic - High contrast black".

When i select the search mode "Quality checks" i have the dropdown where i can select which quality checks i want to apply by checkmarking or de-checkmarking each item in the dropdown list.

With the black background theme, the checkmarks left of the menu items are black too and so render invisible.

To determine which items are checked or not, i have to hover every single item one by one with the mouse to highlight the actual item. Then, with my (green in my case) highlighting background color i can see the checkmark or an empty space (if the item is not checked).

Please see the attached screenshot where BOTH items that the arrows point to are checked, but the checkmark is only visible for the lower, highlighted one where i hovered above in the moment i took the screenshot.

Not a vital problem, but a bit annoying for me. If a kind soul could find time to check and change that, i'd be really glad.

Thanks again for all your effort.

Greetings JoTo

transl8bzimport commented 13 years ago

Originally posted by Joerg Toellner:

Created attachment 764

Showing my problem with a screenshot.

friedelwolff commented 13 years ago

I had a look at this. It seems like another bug in the GTK+ theming, although this time it doesn't seem to be limited to Windows only. I can't affect the theming of the check/tick with the normal GTK theming method, or I'm not able to find the correct settings.

Technical details for if someone wants to look at this again: I think the issue is that the Windows theme (msw_style.c) uses style->black_gc in draw_check() which is probably black regardless of the current theme.

For now we'll let this rest a bit until we maybe get a new/better idea.