Removed depricated code

translate / virtaal

Easy-to-use and powerful offline translation tool

https://virtaal.translatehouse.org

GNU General Public License v2.0

300 stars 58 forks source link

Removed depricated code #3273

Open shahidikram0701 opened 7 years ago

friedelwolff commented 5 years ago

Sorry for only getting to this now.

I currently have Translate Toolkit 2.4.0, and the existing code (with extractpoline) still works. Is it just deprecated, or was the removal reversed? Do we still need this?

unho commented 5 years ago

@friedelwolff If this PR is ok and gets merged, then we would be able to merge PR https://github.com/translate/translate/pull/3596 in Translate Toolkit to get rid of this deprecated function.

unho commented 5 years ago

@friedelwolff Also check PR #3272 which kinda does the same thing as this one.

friedelwolff commented 5 years ago

The two functions are not equivalent:

>>> from translate.storage import pypo
>>> pypo.extractpoline('"abc"')
'abc'
>>> pypo.unescape('"abc"')
'"abc"'

What am I missing?

unho commented 5 years ago

You are right, they are not the same.