translationalneuromodeling / tapas

TAPAS - Translational Algorithms for Psychiatry-Advancing Science
https://translationalneuromodeling.github.io/tapas/
GNU General Public License v3.0
219 stars 90 forks source link

tapas_physio_pca -> no voxel limitation #192

Open benoitberanger opened 2 years ago

benoitberanger commented 2 years ago

This PR responds to #162

CHANGE : tapas_physio_pca

This function now uses the covariance matrix instead of the matrix itself. This strategy is inpired by spm_regions function.

CHANGE : tapas_physio_create_noise_rois_regressors

The function have minor modifications due to the PCA rework. However :

NEW : function tapas_physio_interactive_noiseROI_mask

This function will load a mask and display it using _spmorthviews, apply a threshold + erosion then display the result using an overlay. The noiseROI volume (the overlay) remains in memory, no volume is written. Maybe a feature to add ? A panel is added on spm_orthviews so the threshold and erosion level can be changed and the result visualized dynamicaly. exemple_interactive_ROI

DELETE : tapas_physio_pca_test

The function have been removed, since the approach have changed (covariance matrix) This is a discussion the to have with the devs (@mrikasper). I'm opened to keep the test function, even though it needs to be complitly reworked to keep the old appreach and the new.

benoitberanger commented 2 years ago

TODO

mrikasper commented 2 years ago

Dear Benoit,

My apologies, but I didn't have enough time to include your PR into the upcoming TAPAS release. I am still working with Johanna Bayer on the summer project to improve PhysIO, but it will take a couple of weeks to overhaul everything. I will let you know once we integrate your PR.

All the best, Lars

benoitberanger commented 1 year ago