search

transloadit / java-sdk

Java client for Transloadit upload service
https://transloadit.com
MIT License
11 stars 7 forks source link

Lint code #61

Closed cdr-chakotay closed 3 years ago

cdr-chakotay commented 3 years ago

Linting the codebase as planned.

This is a draft pull request as it should show the current progress to the other maintainers of the repository and provides a platform to discuss the change i've made.

Still to do:

closes #60

Acconut commented 3 years ago

Incredible work! I left a few answers to your questions. Let me know if you have more :)

cdr-chakotay commented 3 years ago

~~It is not 100% complete but let us merge it to avoid further conflicts. I will continue with that besides the other issues.~~ I would like to leave Issue #61 open for the moment :)

I am only lacking to review the Async tests. I guess we can wait for that.

cdr-chakotay commented 3 years ago

Guess we can go live now :D

All checks are passing and the linter runs on the whole repo!

Acconut commented 3 years ago

All checks are passing and the linter runs on the whole repo!

Amazing, incredible work! :heart_eyes: Feel free to merge it! The honor is all yours!

cdr-chakotay commented 3 years ago

@Acconut merged the PR now :)

Acconut commented 3 years ago

Incredible :100: