Enable parallel uploads and fix async. Assemblies

transloadit / java-sdk

Java client for Transloadit upload service

https://transloadit.com

MIT License

11 stars 7 forks source link

Enable parallel uploads and fix async. Assemblies #70

Closed cdr-chakotay closed 2 years ago

cdr-chakotay commented 3 years ago

The aim of this PR is to add full parallel upload support to the Java SDK for both synchronous and asynchronous assemblies.

Archivement Checklist:

[x] Make synchronous Assemblies uploadable in parallel
[x] Make the number of Uploadthreads adjustable
[x] Discuss default settings for the number of upload threads (currently 2)
[x] ~~Make asynchronous Assemblies uploadable in parallel~~ => everything is possible without extra Async Assembly
[x] Make all the changes jUnit testable (open for recommendations)
[x] Make Error reporting better closes #20

Optionals:

~~Fix AsyncAssemblyListener bug~~ => will not be part of this PR
[x] Fix Nullpointer exception bug in async assemblies closes #69

cdr-chakotay commented 3 years ago

Wow, that is very elegant approach! Let me know if this is ready for a proper review once all the TODOs are addressed.

Thank you very much!

I think it is also possible to provide the pause/play functionality of the Async Assembly within this class. I have already a promising sketch running.

I'll let you know as soon as I am ready for a review!

cdr-chakotay commented 3 years ago

@Acconut tweaked error reporting a little bit. I am using the async upload progress listener now to inform the user about broken uploads. Should I add a default configuration, which reports always if something happens ?

Or what kind of thoughts do you have? Open for change requests ;)

Acconut commented 2 years ago

What is the state of this PR? Were you waiting on some more input? :)

cdr-chakotay commented 2 years ago

Honestly postponed it, because all the Gradle and Maven stuff was more urgent. Will continue here, when I am back :)

Acconut commented 2 years ago

Ok, sounds good! Thanks for the feedback!

cdr-chakotay commented 2 years ago

I think I can propose this now for merging. Awaiting your review @Acconut. Let me know if you want further or more detailed unit testing of the changes components.

Acconut commented 2 years ago

Are you waiting on another review from me side here? I am not sure what the state of this PR is ATM.

cdr-chakotay commented 2 years ago

Are you waiting on another review from me side here? I am not sure what the state of this PR is ATM.

Yes, I do :D, and maybe you could try out production on your end as well. I would not like to deliver it with unseen major bugs I didn't recognize

Acconut commented 2 years ago

Let's celebrate the merge :tada: