transloadit / uppy-server

[DEPRECATED] 'Uppy Server' was renamed to 'Companion' and lives inside the Uppy repo no
https://github.com/transloadit/uppy/tree/master/packages/%40uppy/companion
MIT License
114 stars 27 forks source link

Can we get a more descriptive error when uppy-server cannot be reached #64

Closed kvz closed 6 years ago

kvz commented 6 years ago
screen shot 2018-02-19 at 15 31 43
kvz commented 6 years ago

In my case, the error was:

Failed to load https://server.uppy.io/drive/authorized: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'https://vimeo-uppy.now.sh' is therefore not allowed access. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

But it'd be nice to see: Failed to reach Uppy Server at '<url>' I think.

goto-bus-stop commented 6 years ago

This is probably a client side issue—I think fetch purposely doesn't tell JS much about what happened, but we could def do something like "Could not reach Uppy Server" or something.

goto-bus-stop commented 6 years ago

Hah. got sniped!

ifedapoolarewaju commented 6 years ago

@kvz yes, this seems to me like a client issue no?

kvz commented 6 years ago

I think so yes! - Will move it!

kvz commented 6 years ago

Moved to client repo 👌