search

transloadit / uppy-server

[DEPRECATED] 'Uppy Server' was renamed to 'Companion' and lives inside the Uppy repo no
https://github.com/transloadit/uppy/tree/master/packages/%40uppy/companion
MIT License
114 stars 27 forks source link

Should we upgrade to Grant 4? #72

Closed kvz closed 6 years ago

kvz commented 6 years ago

On 14 March 2018 at 15:05:03, Simeon Velichkov (simeonvelichkov@gmail.com) wrote:

:wave: I'm the author of Grant

I've released Grant v4.0, here is the: https://github.com/simov/grant/blob/master/CHANGELOG.md#v400-20180314

Internally I've dropped the request dependency which will result in:

  • less dependencies
  • lower memory footprint of the HTTP server consuming Grant
  • less vulnerability issues constantly popping out of request's deps

There should be only one breaking change regarding the error handling in the final callback based on the transport type used, which should be set to session anyway.

Let me know if you have any issues!

Simo

simov commented 6 years ago

@kvz, thanks for posting this here, I wasn't sure if that's the right place to do it.

Actually @ifedapoolarewaju already tried to upgrade it and he found a minor issue https://github.com/simov/grant/issues/88 that I've managed to fix in v4.0.1 :+1:

ifedapoolarewaju commented 6 years ago

upgraded