Closed goto-bus-stop closed 6 years ago
Typescript doesn't like the req.uppy
references in the S3 controller because the Request
type does not declare an uppy
property. do you know of a way to deal with that?
Hmm, CI can't install the dependency from github because git isn't available. I'll try swapping it for a module from npm
Note: This does not yet implement multipart uploading on the server, so you can't upload from GDrive to S3 using Multipart uploads with this PR.
This patch adds some endpoints to the S3 controller for multipart uploads:
POST /s3/multipart?filename=xyz.jpg
Create a new multipart upload. Returns the UploadId and the object key. (The object key can be different from the input filename, ifgetKey()
is defined server side.)GET /s3/multipart/:uploadId
List parts that have already been uploaded. Returns an array of{ PartNumber, ETag }
objects.GET /s3/multipart/:uploadId/:partNumber?key=xyz.jpg
Get a signed URL to upload a part. Must specify thekey
that you got inPOST /s3/multipart
as a query parameter.DELETE /s3/multipart/:uploadId?key=xyz.jpg
Cancel an upload, discarding parts that were already uploaded. Must specify thekey
that you got inPOST /s3/multipart
as a query parameter.POST /s3/multipart/:uploadId/complete?key=xyz.jpg
Complete an upload. Send a JSON object{ parts }
in the request body. Eachpart
must have aPartNumber
and anETag
. Must specify thekey
that you got inPOST /s3/multipart
as a query parameter.Checkboxes are TODOs.