Adjust S3 client instantiation to handle IAM roles

transloadit / uppy-server

[DEPRECATED] 'Uppy Server' was renamed to 'Companion' and lives inside the Uppy repo no

https://github.com/transloadit/uppy/tree/master/packages/%40uppy/companion

MIT License

114 stars 27 forks source link

Adjust S3 client instantiation to handle IAM roles #84

Closed DavidJFelix closed 6 years ago

DavidJFelix commented 6 years ago

Fix serverless example to use lambda role rather than IAM user Lambda provides environment variables for AWS SDK. See: https://docs.aws.amazon.com/lambda/latest/dg/current-supported-versions.html
Make S3 client creation to conditionally set credentials, so unspecified credentials will use instance/envioronment defaults.
Utilize credentials rather than key/secret directly as this also allows session token, which is necessary for STS tokens.

goto-bus-stop commented 6 years ago

Thanks for the PR! Don't have time to look at this right now but I think we should also keep supporting key/secret auth because some mostly-API-compatible alternatives like DigitalOcean Spaces don't support IAM

DavidJFelix commented 6 years ago

@goto-bus-stop Its should be noted: this will still utilize key/secret if you provide them.

The way this works is:

✅ If you provide key,secret only, it operates the same way. 🆕 If you provide key,secret,session (how a role using STS will provide credentials) it will now use the session token also 🆕 If you provide nothing, it will use environment variables

goto-bus-stop commented 6 years ago

Oh, I see now! The process.env stuff was only removed from the serverless example. That makes sense. Thanks for the clarification :)