search

transloadit / uppy-server

[DEPRECATED] 'Uppy Server' was renamed to 'Companion' and lives inside the Uppy repo no
https://github.com/transloadit/uppy/tree/master/packages/%40uppy/companion
MIT License
114 stars 27 forks source link

Make use of forked roles #9

Closed tersmitten closed 7 years ago

ifedapoolarewaju commented 7 years ago

@tersmitten these changes are still breaking deployment builds. Is there anything required to do to make it work as expected?

tersmitten commented 7 years ago

Yes, If @kvz releases a new version of freyproject/frey builds shouldn't fail anymore.

ifedapoolarewaju commented 7 years ago

@tersmitten would it make sense to revert this merge and wait till the new release is out? Since it's preventing deployment from going through right now.

kvz commented 7 years ago

Just released Frey v0.3.27, will try to upgrade our projects now

kvz commented 7 years ago

@tersmitten besides these replacements:

replace "/v(\d+.\d+.\d+)" '/$1' "${freyFile}"
replace "/apt/(\d+.\d+.\d+)" 'apt/1.3.0' "${freyFile}"

are there more that I should add?

kvz commented 7 years ago

Never mind, I found a good approach now

kvz commented 7 years ago

Here's a list of the PRs, please review:

https://github.com/transloadit/uppy-server/pull/10 https://github.com/tus/tusd/pull/85 https://github.com/transloadit/infra-imagemagick/pull/3

tersmitten commented 7 years ago

I'll have a look at them

kvz commented 7 years ago

Gave you commit access to infra-imagemagick also