transloadit / uppy.io

The Uppy website
https://uppy.io
11 stars 27 forks source link

@uppy/companion: support non-aws S3 endpoints via environment variables #178

Closed lukvermeulen closed 10 months ago

lukvermeulen commented 10 months ago

Initial checklist

I am aware of a custom solution like here: https://github.com/transloadit/uppy/blob/main/examples/digitalocean-spaces/server.cjs#L39 but prefer not to write my own server files etc. if possible - just to specify a different s3 endpoint.

Problem

I am using a docker-compose file to host the transloadit/companion image. I found options to declare AWS S3 secret, key etc. but not to specify the s3 endpoint in the .env file / environment.

Solution

I'd like to be able to define a COMPANION_S3_ENDPOINT in the .env file or environment settings to use other s3 compatible storage providers.

Alternatives

config files or other settings. I'd prefer this configuration to be as simple as possible. If I overlooked a similar setting - sorry! I'm happy to hear about that.

Murderlon commented 10 months ago

@mifi if we support it in code I think we should support this in a env var too?

mifi commented 10 months ago

Cant you use https://github.com/transloadit/uppy/blob/39a2d3f892bc4bf24449fa2d1f9ef406f2d3a848/packages/%40uppy/companion/src/standalone/helper.js#L125

Murderlon commented 10 months ago

We don't document this 😯 https://uppy.io/docs/companion/#s3