transloadit / uppy

The next open source file uploader for web browsers :dog:
https://uppy.io
MIT License
29.14k stars 2.01k forks source link

Smoke test uppy.io on CI deploy #4226

Open mifi opened 1 year ago

mifi commented 1 year ago

Initial checklist

Problem

We have sometimes been surprised that uppy.io has been broken without us knowing

Solution

Create a simple smoke test (browser test?) of for example uploading a file from an URL - which will hit the multiple Companion instances.

Because uppy.io now runs with two instances of companion behind a load balancer, this will make sure that companion works properly with multiple instances (which is hard to forget to check when developing locally)

Alternatives

Make a functional test as part of the test suite, but then we need to do a lot of extra configuring and setting up a local load balancer etc, so a smoke test could be a shortcut. See also https://github.com/transloadit/uppy/issues/3538

Murderlon commented 1 year ago

I think we can close this as we're close to a new website in a different repository, which AFAIK will be rebuild on new releases, which are far more likely to be stable. Alternatively, we transfer this issue to that repo and create an e2e test.

arturi commented 1 year ago

I am for this independent test that just tests Uppy.io and annoyingly emails me if it fails to upload via URL. I can look into implementing this.