search

transmission-remote-gui / transgui

🧲 A feature rich cross platform Transmission BitTorrent client. Faster and has more functionality than the built-in web GUI.
GNU General Public License v2.0
3.24k stars 281 forks source link

Incorrect type of paused argument on torrent-add RPC #1415

Open jpmikkers opened 2 years ago

jpmikkers commented 2 years ago

OS: windows 11 Transmission deamon: custom, based on transmission RPC spec Transmission remote GUI: v5.18.0

Transgui sends the paused argument of torrent-add as an integer, but this should be a boolean (i.e. true/false).

See: https://github.com/transmission-remote-gui/transgui/blob/5849c13c002184f6139e2c701edb0d5b0af1bfad/main.pas#L2675

and: https://github.com/transmission-remote-gui/transgui/blob/5849c13c002184f6139e2c701edb0d5b0af1bfad/main.pas#L2764

Spec: https://github.com/transmission-remote-gui/transgui/blob/5849c13c002184f6139e2c701edb0d5b0af1bfad/rpc-spec.txt#L368

Transmissions own web-ui does send it as a bool.

jpmikkers commented 2 years ago

p.s. the integer only works because transmission has a really relaxed attitude towards what is correct json or not.